[client] Populate NetworkAddresses on iOS for posture checks#5900
Merged
pappz merged 1 commit intonetbirdio:mainfrom Apr 16, 2026
Merged
[client] Populate NetworkAddresses on iOS for posture checks#5900pappz merged 1 commit intonetbirdio:mainfrom
pappz merged 1 commit intonetbirdio:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughThe iOS Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The iOS GetInfo() function never populated NetworkAddresses, causing the peer_network_range_check posture check to fail for all iOS clients. This adds the same networkAddresses() call that macOS, Linux, Windows, and FreeBSD already use. Fixes: netbirdio#3968 Fixes: netbirdio#4657
MichaelUray
force-pushed
the
fix/ios-network-addresses
branch
from
268fc99 to
46733dc
Compare
|
pappz
approved these changes
Apr 16, 2026
7 tasks
MichaelUray
added a commit
to MichaelUray/netbird
that referenced
this pull request
Apr 17, 2026
Upstream netbirdio#5900 added networkAddresses() to info_ios.go. Since this PR updates the networkAddresses() signature to require context (for the Android external iface discoverer), the iOS caller needs the same ctx argument.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS
GetInfo()function never populatedNetworkAddresses, causing thepeer_network_range_checkposture check to fail for all iOS clients. The management server received emptyNetworkAddressesand either blocked the peer entirely or could not evaluate network-based policies.This adds the same
networkAddresses()call that macOS, Linux, Windows, and FreeBSD already use. The function is available in the sharedinfo.goand works on iOS vianet.Interfaces().Changes
client/system/info_ios.go: CallnetworkAddresses()and populateNetworkAddressesfield in theInfostruct, matching the pattern used by all other platformsRelated Issues
Fixes #3968 — Posture checks peer network range failed on iPhone
Fixes #4657 — iOS Client loses all routes when Posture Checks are enabled
Testing
This change cannot be tested without macOS + Xcode. However:
networkAddresses()function is already compiled into the iOS binary (sharedinfo.go)net.Interfaces()is available on iOS and returns interface information within the Network Extension sandboxChecklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
Summary by CodeRabbit
New Features
Bug Fixes